Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STD support for PSVita #110638

Merged
merged 1 commit into from
May 8, 2023
Merged

STD support for PSVita #110638

merged 1 commit into from
May 8, 2023

Conversation

nikarh
Copy link
Contributor

@nikarh nikarh commented Apr 21, 2023

This PR adds std support for armv7-sony-vita-newlibeabihf target.

The work here is fairly similar to #95897, just for a different target platform.

This depends on the following pull requests:

rust-lang/backtrace-rs#523
rust-lang/libc#3209

@rustbot
Copy link
Collaborator

rustbot commented Apr 21, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot
Copy link
Collaborator

rustbot commented Apr 21, 2023

⚠️ Warning ⚠️

  • These commits modify submodules.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 21, 2023
@rustbot
Copy link
Collaborator

rustbot commented Apr 21, 2023

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

These commits modify compiler targets.
(See the Target Tier Policy.)

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@nikarh nikarh closed this Apr 26, 2023
@nikarh nikarh reopened this Apr 26, 2023
@nikarh
Copy link
Contributor Author

nikarh commented Apr 26, 2023

Sorry for the force-push spam.

rust-lang/libc#3209 is merged, rust-lang/backtrace-rs#523 is waiting for review.

I would rather wait until libc is released and backtrace-rs is merged, so I'll convert this PR to draft for now.

@nikarh nikarh marked this pull request as draft April 26, 2023 15:49
@nikarh nikarh mentioned this pull request May 2, 2023
Merged
@Mark-Simulacrum
Copy link
Member

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 6, 2023
@nikarh
Copy link
Contributor Author

nikarh commented May 6, 2023

Now that libc is released, waiting for rust-lang/backtrace-rs#523 to be merged (I assume CI has to be fixed first for rust nightly in its master, but that's out of the scope of my PRs).

After that, I'll update and un-draft this PR.

@nikarh nikarh marked this pull request as ready for review May 7, 2023 12:26
@rustbot
Copy link
Collaborator

rustbot commented May 7, 2023

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@nikarh nikarh requested a review from wesleywiser May 7, 2023 14:31
@nikarh
Copy link
Contributor Author

nikarh commented May 7, 2023

@rustbot label -S-waiting-on-author +S-waiting-on-review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 7, 2023
@Mark-Simulacrum
Copy link
Member

Please squash commits, r=me with that done.

@bors
Copy link
Contributor

bors commented May 7, 2023

@nikarh: 🔑 Insufficient privileges: Not in reviewers

@nikarh
Copy link
Contributor Author

nikarh commented May 7, 2023

@bors r=Mark-Simulacrum

@bors
Copy link
Contributor

bors commented May 7, 2023

@nikarh: 🔑 Insufficient privileges: Not in reviewers

@cjgillot
Copy link
Contributor

cjgillot commented May 7, 2023

@bors r=Mark-Simulacrum

@bors
Copy link
Contributor

bors commented May 7, 2023

📌 Commit 3ba3df3 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 7, 2023
@JohnTitor JohnTitor mentioned this pull request May 8, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 8, 2023
@bors
Auto merge of rust-lang#111346 - JohnTitor:rollup-6g5cg9z, r=JohnTitor
ce04288 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#105354 (Add deployment-target --print flag for Apple targets)
 - rust-lang#110377 (Update max_atomic_width of armv7r and armv7_sony_vita targets to 64.)
 - rust-lang#110638 (STD support for PSVita)
 - rust-lang#111211 (Don't compute trait super bounds unless they're positive)
 - rust-lang#111315 (Remove `identity_future` from stdlib)
 - rust-lang#111331 (Mark s390x condition code register as clobbered in inline assembly)
 - rust-lang#111332 (Improve inline asm for LoongArch)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 4df84a1 into rust-lang:master May 8, 2023
@rustbot rustbot added this to the 1.71.0 milestone May 8, 2023
@BlackSheepBoy69
Copy link

Does it output as a .vpk file or an eboot.bin? Do you need VitaSDK to use this for Vita?

@nikarh
Copy link
Contributor Author

nikarh commented May 18, 2023

Does it output as a .vpk file or an eboot.bin? Do you need VitaSDK to use this for Vita?

All relevant doc is here:
https://doc.rust-lang.org/nightly/rustc/platform-support/armv7-sony-vita-newlibeabihf.html

tldr; you can create a static lib in Rust, link it with VitaSDK to an elf, and then do the rest up to vpk with VitaSDK tools.
If you need any help, I suppose it's better to contact me directly, instead of here.

@davidtwco davidtwco mentioned this pull request Sep 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesleywiser wesleywiser Awaiting requested review from wesleywiser

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.
8 participants
@nikarh @rustbot @rust-log-analyzer @Mark-Simulacrum @bors @cjgillot @BlackSheepBoy69 @wesleywiser